docsify icon indicating copy to clipboard operation
docsify copied to clipboard

Fix the end condition for the embed content handling loop

Open julienw opened this issue 3 years ago • 3 comments

Fixes #1822

Summary

This changes (and effectively fixes) the end condition for the embeds handling loop.

What kind of change does this PR introduce?

Bugfix

For any code change,

  • [X] Related documentation has been updated if needed
  • [ ] Related tests have been updated or tests have been added

I didn't see any test related to embed but I'd be happy to update some if needed.

I especially looked at the "embed" page in the documentation, and everything looked good in my opinion.

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [X] No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

#1822

Tested in the following browsers:

  • [X] Chrome
  • [X] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

julienw avatar Jun 22 '22 14:06 julienw

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 6:11am

vercel[bot] avatar Jun 22 '22 14:06 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 73dc6d601005f8175b394dc57ef337f50794c297:

Sandbox Source
docsify-template Configuration
problem-with-docsify Issue #1822
problem-with-docsify Issue #1822

codesandbox-ci[bot] avatar Jun 22 '22 14:06 codesandbox-ci[bot]

@sy-records @Koooooo-7 gently ping for this simple patch :-)

julienw avatar Aug 30 '22 07:08 julienw

up! thanks for your consideration

julienw avatar Dec 13 '22 14:12 julienw