docsify icon indicating copy to clipboard operation
docsify copied to clipboard

Fix: When relativePath: false, use root absolute paths are for images…

Open ikfly opened this issue 2 years ago • 2 comments

…ve method as use same router with markdown file then remove beginning # (#877、#850)

Summary

When relativePath: false, use root absolute paths for images,a small change as use same router with .md file ,fix #877、#850

What kind of change does this PR introduce?

Bugfix

For any code change,

  • [ ] Related documentation has been updated if needed
  • [ ] Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

#877 #850

Tested in the following browsers:

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

my tests

  • relativePath: false
currentPath: /doc/home
href: images/myImage.png
url: /images/myImage.png
currentPath: /doc/home
href: https://github.com/docsifyjs/docsify/blob/develop/docs/_images/zh-cn/nested-navbar.png
url: https://github.com/docsifyjs/docsify/blob/develop/docs/_images/zh-cn/nested-navbar.png
  • relativePath: true
currentPath: /doc/home
href: images/myImage.png
url: /doc/images/myImage.png
currentPath: /doc/home
href: https://github.com/docsifyjs/docsify/blob/develop/docs/_images/zh-cn/nested-navbar.png
url: https://github.com/docsifyjs/docsify/blob/develop/docs/_images/zh-cn/nested-navbar.png

ikfly avatar Apr 22 '22 07:04 ikfly

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docsify-preview ✅ Ready (Inspect) Visit Preview Jul 8, 2022 at 10:48AM (UTC)

vercel[bot] avatar Apr 22 '22 07:04 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1c8c59ded42b457ef6f5a3ca726439597b4c99e3:

Sandbox Source
docsify-template Configuration

codesandbox-ci[bot] avatar Apr 22 '22 07:04 codesandbox-ci[bot]