docpad-skeleton-syte icon indicating copy to clipboard operation
docpad-skeleton-syte copied to clipboard

undefined in menu if you do not have account for media

Open bryanrasmussen opened this issue 11 years ago • 2 comments

I was just checking out the plugin, decided it wasn't what I was expecting/wanted but I did notice that the links in the social media menu ended up with an undefined at the end if you didn't actually have an account for that service.

I noticed it because my .env file for testing was just

GITHUB_USERNAME=bryanrasmussen GITHUB_CLIENT_ID= GITHUB_CLIENT_SECRET=

bryanrasmussen avatar Sep 06 '13 19:09 bryanrasmussen

You must include all the necessary fields for a particular service. We should error about this though. Would you be able to add the necessary checks and error messages?

balupton avatar Sep 07 '13 03:09 balupton

You must include all the necessary fields for a particular service No, I didn't have any of the necessary fields for any of the services other than github, so probably it shouldn't show any of those services over in the menu. If it does show it in the menu then I guess it should show them grayed out non-links or something. Anyway it was just something I noticed after I started it up.

Thanks, Bryan Rasmussen

On Sat, Sep 7, 2013 at 5:45 AM, Benjamin Arthur Lupton < [email protected]> wrote:

You must include all the necessary fields for a particular service. We should error about this though.

— Reply to this email directly or view it on GitHubhttps://github.com/docpad/syte.docpad/issues/10#issuecomment-23980942 .

bryanrasmussen avatar Sep 07 '13 10:09 bryanrasmussen