docpad-plugin-cleanurls icon indicating copy to clipboard operation
docpad-plugin-cleanurls copied to clipboard

hard-coded static env name

Open 1000i100 opened this issue 11 years ago • 5 comments

line 80 in your src plugin code there is :

Static

if 'static' in docpad.getEnvironments()

the static features could also be triggered by a custom parameters to not enforce static env name use. It could improve compatibility with other plugin using env specific rules.

1000i100 avatar Jul 01 '13 06:07 1000i100

Nice suggestion :+1: Any thoughts on what a possible implementation could look like?

balupton avatar Jul 01 '13 06:07 balupton

i'm not enough familiar with docpad internals to know how to add custom parameters in config files or command line. Perhaps some time later, right now, i'm just discovering and testing docpad ecosystem.

1000i100 avatar Jul 01 '13 07:07 1000i100

Cool, no worries.

balupton avatar Jul 01 '13 07:07 balupton

https://github.com/docpad/docpad-plugin-cleanurls/pull/14 ?

RobLoach avatar Feb 07 '14 21:02 RobLoach

Fixed in v2.7.0. Note that I've made some changes, see the readme.

balupton avatar Feb 13 '14 02:02 balupton