docopt icon indicating copy to clipboard operation
docopt copied to clipboard

py25, py34, Changelog, Readme, Makefile

Open Grokzen opened this issue 11 years ago • 5 comments

This PR contain multiple changes.

  • Python 2.5 was removed from tox.ini because travis can no longer run tests on python 2.5. (http://blog.travis-ci.com/2013-11-18-upcoming-build-environment-updates/)
  • Python 3.4 was added to tox.ini. It passes all tests and can be added as supported enviroment.
  • Moved all changelog related text (There was x2 of them in Readme) into new file.
  • Append changelog to end of long_description
  • Random updates to Readme.rst to make it look better
  • ~~Added Makefile so that the repo can be cleaned up from tmp files more easily.~~

Grokzen avatar Jun 24 '14 01:06 Grokzen

Changelog changes are good. I would recommend appending them to the long_description in setup.py like this: https://github.com/kennethreitz/requests/blob/master/setup.py#L39

Not fan of the makefile and clean target. git-clean is normally used for this.

keleshev avatar Jun 24 '14 13:06 keleshev

Oh i did not know about git-clean :p That is a better command to use then the Makefile.

The long_description addition sounds good to.

What about py25 changes? Is that something critical to keep or not? Should there be 2 ways to test, one for local where py25 work and one for travis-ci where py25 do not work?

Grokzen avatar Jun 24 '14 16:06 Grokzen

I want to add release 0.1.1 and 0.4.1 to Changelog that i missed in previous commits, what should i write as changes for those 2 releases?

Grokzen avatar Jun 24 '14 16:06 Grokzen

:+1:

Zearin avatar Apr 28 '15 16:04 Zearin

This PR is a bit old, but I see merged https://github.com/docopt/docopt/pull/319 has since removed 2.5 from tox.ini and added 3.4 and 3.5.

hugovk avatar Oct 11 '17 16:10 hugovk