windows icon indicating copy to clipboard operation
windows copied to clipboard

[Feature]: Keep original isos

Open sequencerr opened this issue 7 months ago • 6 comments

Is your proposal related to a problem?

It takes time to download different isos(potentially producing rate-limit from ms-servers) and hop between then. For example, even for single iso, I want to experiment with answers file, it has to build new ISO from original every time by re-downloading it.

Describe the solution you'd like.

Keep the tmp folder in some way.

Describe alternatives you've considered.

There is undocumented flag, but it's only to keep OS installation data. https://github.com/dockur/windows/issues/567#issuecomment-2154295972

Additional context

No response

sequencerr avatar Jun 13 '25 09:06 sequencerr

Since there is "❯ Detected that the version was changed, but ignoring this because Windows is already installed." I should follow steps described in that Issue, keeping /storage folders separate at least, but problem with answer files retains. (And it was kinda intuitive that I cannot rewrite installation, keeping same folder, but downloading multiple original isos in cache folder, but should instead create different storage folder for each version.)

sequencerr avatar Jun 13 '25 09:06 sequencerr

I don't really understand the problem. There is a flag to preserve the .iso (REMOVE: "N") which should do exactly what you want. And you can supply a /boot.iso from your compose file, to prevent downloading it before installation. So what is missing?

kroese avatar Sep 18 '25 18:09 kroese

when it slightly(most commonly when changing oem script, but i also change answers file a bit often) have to change final image, it does complete process from beginning (including downloading official iso from the beginning). I've made some chande to code, can create pr later, but not sure I covered all cases or didn't touch what i shouldn't have. but it worked for me. and my changes dont completely unify logic. like what should be temp dir, cache. because I don't really like current logic tho it's okay since all is temp now but still strange internally kinda cuz has nested temp(to be exact for unzipping)

sequencerr avatar Sep 18 '25 18:09 sequencerr

yep i totally could set just custom iso. but we have logic when specifying win version to download original iso. and from tool end user pov oem changes shouldn't redownload each time original iso.

tho not really an argument cuz I working with guts of this tool, i like to modify answers file and let builder inside this tool do it's job to build final image.

sequencerr avatar Sep 18 '25 18:09 sequencerr

users might also want to keep downloaded original isos just so they would have them.

sequencerr avatar Sep 18 '25 18:09 sequencerr

users might also want to keep downloaded original isos just so they would have them.

that is exactly what the REMOVE=N flag is for.

kroese avatar Sep 18 '25 19:09 kroese