DAG is wrong for CWL workflows with subworkflows

[wshands]

Describe the bug The DAG is incorrect for workflow github.com/hubmapconsortium/sc-atac-seq-pipeline/HuBMAP_scATAC-seq_Pipeline:feature/remove-curly-braces after fixing https://github.com/dockstore/dockstore/issues/3349

To Reproduce Steps to reproduce the behavior:

1. Go to github.com/hubmapconsortium/sc-atac-seq-pipeline/HuBMAP_scATAC-seq_Pipeline:feature/remove-curly-braces
2. Click on DAG tab
3. See incorrect DAG

Expected behavior A DAG with at least 10 steps should be displayed with only one step arriving at the End node

Screenshots Incorrect DAG

Desktop (please complete the following information):

• OS: iOS
• Browser Google Chrome
• Version Version 80.0.3987.132 (Official Build) (64-bit)

Additional context

• UI version: 2.5.1
• Webservice version: 1.8.1
• host location: localhost:4200://dockstore.org

┆Issue is synchronized with this Jira Bug ┆fixVersions: Open-ended research tasks ┆friendlyId: DOCK-1282 ┆sprint: Backlog ┆taskType: Bug

[agduncan94]

I believe if there is a nested workflow in a DAG, it will show one step with that workflow instead of showing that nested workflows individual steps. I do not remember if this was due to a parsing limitation or we just didn't get to it. I wouldn't necessarily call this an error though but it may be cool to also parse sub workflows (if possible).

[unito-bot]

➤ Walt Shands commented:

It seems that the workflow parser only looks for workflow steps one level down; if there are subworkflow steps that also have steps they are not found.

[wshands]

Also a problem for https://github.com/dockstore-testing/multi-step-cwl

[unito-bot]

➤ Denis Yuen commented:

Ben Vizzier we can chat about this on, relates to curtailment

[unito-bot]

➤ Ben Vizzier commented:

Denis & I discussed the scheduling of the release. I’m flexible on when it is actually released.

[coverbeck]

Also happens with WDL. See https://discuss.dockstore.org/t/dags-are-broken-for-wdl-pipelines-that-use-subworkflows/8048/2