dockstore-ui2 icon indicating copy to clipboard operation
dockstore-ui2 copied to clipboard

Feature/seab 6279/angular material

Open coverbeck opened this issue 2 months ago • 3 comments

Description Upgrades to Angular MDC Material from the legacy components we are using today.

Why? Because Angular Material 17 dropped the legacy components. This means we can't upgrade to Angular 17 and stay current. Angular 16, our current version, is already no longer actively supported.

The Migration

  • Following this guide.
  • Main issues
    • Selectors in the cypress tests relying on "internal classes"
    • Styling (hard to find)

Review Instructions Describe if this ticket needs review and if so, how one may go about it in qa and/or staging environments. For example, a ticket based on Security Hub, Snyk, or Dependabot may not need review since those services will generate new warnings if the issue has not been resolved properly. On the other hand, an infrastructure ticket that results in visible changes to the end-user will definitely require review. Many tickets will likely be between these two extremes, so some judgement may be required.

Issue A link to a github issue or SEAB- ticket (using that as a prefix)

Security If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • [ ] Check that your code compiles by running npm run build
  • [ ] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • [ ] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • [ ] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • [ ] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • [ ] Do not use cookies, although this may change in the future
  • [ ] Run npm audit and ensure you are not introducing new vulnerabilities
  • [ ] Do due diligence on new 3rd party libraries, checking for CVEs
  • [ ] Don't allow user-uploaded images to be served from the Dockstore domain
  • [ ] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • [ ] Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

coverbeck avatar Dec 19 '24 01:12 coverbeck