dockstore-ui2
dockstore-ui2 copied to clipboard
DOCK-2312: Add warning to Entry page that GitHub App might be uninstalled
Description This PR adds a "yellow box" warning to the private Entry page that is displayed when the GitHub App appears to be uninstalled:
The button has the same text as the button that's displayed in the registration interface.
Review Instructions Register an entry on qa via our GitHub App, and view the private page. Confirm that the warning is not displayed. Uninstall our GitHub App on the repository containing the entry. Wait five minutes. Reload the private page, and confirm that the warning is displayed. Click on the button and reinstall the App on the repo. Wait five minutes. Confirm that the warning is displayed.
Issue https://ucsc-cgl.atlassian.net/browse/DOCK-2312 https://github.com/dockstore/dockstore/issues/5331
Security No security concerns.
Please make sure that you've checked the following before submitting your pull request. Thanks!
- [x] Check that your code compiles by running
npm run build
- [x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
- [x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
- [x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
- [x] If displaying markdown, use the
markdown-wrapper
component, which does extra sanitization - [x] Do not use cookies, although this may change in the future
- [x] Run
npm audit
and ensure you are not introducing new vulnerabilities - [x] Do due diligence on new 3rd party libraries, checking for CVEs
- [x] Don't allow user-uploaded images to be served from the Dockstore domain
- [x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
- [x] Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.
Codecov Report
Attention: Patch coverage is 0%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 40.32%. Comparing base (
30d4692
) to head (4963299
). Report is 2 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
src/app/workflow/workflow.component.ts | 0.00% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## develop #1965 +/- ##
===========================================
- Coverage 40.33% 40.32% -0.02%
===========================================
Files 400 400
Lines 11954 11957 +3
Branches 2894 2894
===========================================
Hits 4822 4822
- Misses 4843 4846 +3
Partials 2289 2289
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.