dockstore-ui2 icon indicating copy to clipboard operation
dockstore-ui2 copied to clipboard

re-order and recommend github apps for tools

Open denis-yuen opened this issue 2 years ago • 2 comments

Description Recommend GitHub app registration for tools

Review Instructions GitHub apps is now the recommended tool (not just workflow) registration type. Dialog box should work when trying different options

Issue https://github.com/dockstore/dockstore/issues/4857

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • [x] Check that your code compiles by running npm run build
  • [x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • [x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • [x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • [x] Do not use cookies, although this may change in the future
  • [x] Run npm audit and ensure you are not introducing new vulnerabilities
  • [x] Do due diligence on new 3rd party libraries, checking for CVEs
  • [x] Don't allow user-uploaded images to be served from the Dockstore domain
  • [x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

denis-yuen avatar Dec 08 '22 19:12 denis-yuen

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Dec 08 '22 20:12 sonarqubecloud[bot]

Codecov Report

Base: 43.09% // Head: 43.09% // No change to project coverage :thumbsup:

Coverage data is based on head (30fce9e) compared to base (7120785). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1661   +/-   ##
========================================
  Coverage    43.09%   43.09%           
========================================
  Files          314      314           
  Lines         9702     9702           
  Branches      2470     2470           
========================================
  Hits          4181     4181           
  Misses        3469     3469           
  Partials      2052     2052           
Impacted Files Coverage Δ
...rc/app/home-page/home-logged-out/home.component.ts 65.78% <0.00%> (-2.64%) :arrow_down:
...me-page/home-logged-in/home-logged-in.component.ts 59.09% <0.00%> (+4.54%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Dec 08 '22 20:12 codecov[bot]