service-cli icon indicating copy to clipboard operation
service-cli copied to clipboard

Upgrade SQLite to 3.45 for Drupal 11

Open jhedstrom opened this issue 1 year ago • 1 comments

Closes #326

jhedstrom avatar Oct 08 '24 19:10 jhedstrom

I did run into this and appreciate the PR. I wasn't quite sure how to test it. What I ended up doing was to extend the docksal stock cli image like this, with the changes taken from this PR:

FROM docksal/cli:php8.3-3

# Upgrade SQLite for Drupal 11 testing.
# @see https://www.drupal.org/project/drupal/issues/3346338
RUN set -xe; \
  echo "deb https://deb.debian.org/debian testing main" | tee /etc/apt/sources.list.d/testing.list; \
  apt-get update >/dev/null; \
  apt-get install -y -t testing sqlite3;\
  # Cleanup
  apt-get clean; rm -rf /var/lib/apt/lists/*

This works like a charme and makes my local tests run again.

This is definitely needed to be able to run test when using docksal with Drupal 11. The Drupal core issue about reverting the requirements looks a bit stale by now [11.x] [policy] Set the SQLite minimum requirement to at least 3.45

berliner avatar Jan 27 '25 22:01 berliner

@jhedstrom Thanks for your contribution! I've expanded it to cover all currently supported PHP versions (8.1, 8.2, 8.3, 8.4). I've merged your original commit to give the credit :)

lmakarov avatar Apr 28 '25 10:04 lmakarov

@lmakarov great, thank you!

I realized though that we've been using a slightly different approach upstream from this to upgrade sqlite that seems to work better. Should I open another PR with these updates?

jhedstrom avatar Apr 29 '25 17:04 jhedstrom

@jhedstrom What are the side effects refered to here?

https://github.com/phase2/docker-cli/blob/d001f2d0ddd5e387451323338a35e47943188917/src/Dockerfile#L50

I've adjusted the original method slightly to drop the testing repo list right after the install. This way, it will not affect future package installations.

lmakarov avatar Apr 29 '25 19:04 lmakarov

@lmakarov ah, yes, the issue was packages installed subsequently from the testing repo. Your fix should resolve those side effects as well. Thanks again!

jhedstrom avatar Apr 29 '25 20:04 jhedstrom