crypto-wasm-ts icon indicating copy to clipboard operation
crypto-wasm-ts copied to clipboard

Build/updates crypto wasm to version 0.34.0

Open lanterno opened this issue 5 months ago • 3 comments

This PR come as a consequence for the PR https://github.com/docknetwork/crypto-wasm/pull/19

Description

The main changes in this PR are

  1. Removing usage of the old version of the proof_system crate. This comes with massive deletion of test cases as they were using the deleted code
  2. Updates the smcParams functions and tests based on the changes in crypto-wasm and crypto library/crate.

PR checklist

  • [x] Verified all tests passed locally with the new version of crypto-wasm on node version 24

For testing using the unpublished newer version of crypto-wasm, I used the new yarn syntax for depending on a library from another directory

"crypto-wasm-new": "portal:../crypto-wasm",

Next step:

  • If this PR is okay, we can go back to crypto-wasm and move forward with the next one or PRs, make a release then update this library with a new release as well.

  • However, the tests I've deleted in the file https://github.com/docknetwork/crypto-wasm-ts/pull/43/files#diff-18fbcee9409debce9f00000e0a60d74a0afb776cc11eac8b5b609c574349749d definitely need an audit by @lovesh

Note

This PR is going to remain in Draft mode until the crypto-wasm library is published with a newer version.

lanterno avatar Sep 08 '25 16:09 lanterno

CI error

Run yarn install --frozen-lockfile
  yarn install --frozen-lockfile
  shell: /usr/bin/bash -e {0}
  env:
    TEST_SIGNATURE_SCHEME: BBS+
error This project's package.json defines "packageManager": "[email protected]". However the current global version of Yarn is 1.22.22.

Presence of the "packageManager" field indicates that the project is meant to be used with Corepack, a tool included by default with all official Node.js distributions starting from 16.9 and 14.19.
Corepack must currently be enabled by running corepack enable in your terminal. For more information, check out https://yarnpkg.com/corepack.

lovesh avatar Nov 07 '25 12:11 lovesh

@lovesh I'm aware of this error. If you look at this exact line, you'll see that I'm using portal which looks for crypto-wasm locally. This is to help you test this locally with crypto-wasm with the latest changes.

Otherwise, we can update this PR to point to [email protected] but after you do another release, because otherwise this build will fail anyway as requires the latest changes on the crypto-was to work.

Does this make sense?

lanterno avatar Nov 07 '25 13:11 lanterno

@lanterno version 0.35.0 is published now.

lovesh avatar Nov 18 '25 04:11 lovesh

@lovesh Just updated the version, and now all tests are succeeding on this PR :)

lanterno avatar Nov 24 '25 13:11 lanterno

Thank you @lanterno

lovesh avatar Nov 25 '25 11:11 lovesh