OpenStack driver should accept multiple --openstack-net-id switches

[robertjustjones]

The OpenStack driver accepts only a single network option (id or name) which overrides the default connection(s).

[robertjustjones]

The PR accepts a comma separated list of net-id's or net-name's for openstack and rackspace drivers.

[nathanleclaire]

cc @ggiamarchi

[fsoppelsa]

@nathanleclaire what is status of this issue?

[nathanleclaire]

@fsoppelsa Not actively being worked on, but happy to take PRs.

Would be great to see some suggestions for developing against the OpenStack driver as well, I am not too familiar with it.

[fsoppelsa]

@nathanleclaire seems the PR is abandoned.

I am in favor to add this to drivers/openstack, but it's not clear which one of the networks will be the one where docker-machine will communicate. From the code I see that a list of networks is loaded, but I don't understand which one will become default. I would like to hear from @robertjustjones

[robertjustjones]

I no longer have access to the environment to test against. My main environment was Rackspace then. The idea was that (outside docker-machine) a machine could be set up with network interfaces for Public/eth0, Rackspace/Private/eth1 and Custom/Private/eth2. The new config switches implemented in the PR enable docker-machine to do the same. I don't know but suspect that the first interface would be the default for docker-machine. I hope that helps.

[fsoppelsa]

Thanks @robertjustjones do you think you will have a chance to rebase and resubmit the PR?

[robertjustjones]

@fsoppelsa I've rebased the code. Can you try it out from https://github.com/robertjustjones/machine.git from branch rackspace-net-switches ? (It includes openstack)

[fsoppelsa]

@robertjustjones yes https://github.com/docker/machine/pull/2974

[robertjustjones]

Thanks @fsoppelsa. Mind trying again from https://github.com/robertjustjones/machine/tree/rackspace-net-switches?

[fsoppelsa]

Yeah recompiled again that branch (apology I had some shell variables that conflicted yesterday, so partly my fault).

Seems working fine with two networks (did you test with > 2)? Also in combination with other relevant driver options, I end up with a provisioned machine.

@nathanleclaire @dgageot for me it's OK for merge. There is a red test though. That, idk.

[robertjustjones]

@fsoppelsa I did just successfully test with 3 networks using this command

./bin/docker-machine-Darwin-x86_64 --debug  create \
  --driver openstack \
  --openstack-flavor-id 2 \
  --openstack-floatingip-pool public \
  --openstack-sec-groups default \
  --openstack-ssh-user ubuntu \
  --openstack-image-id cb6b7936-d2c5-4901-8678-c88b3a6ed84c \
  --openstack-net-name one,two,three  \
  u1

I'll try to figure out the red test.

[robertjustjones]

ok, fixed whitespace, all checks pass again now #2974 . Thanks!!

[fsoppelsa]

Cool!

[felicienfrancois]

What is the status of this issue ? Last PR seems to have been merged and then rollbacked. Is there any plan to fix this ?

[jonathon2nd]

Is there any chance of this being worked?