libkv

libkv copied to clipboard

[redis] add redis backend

4

1. imp interface of libkv with redis command and lua script 2. use key space notification for watchXXX/Lock features, so only work for redis version >= 2.8.0 noted: this implementation...

hsinhoyeh

When multiple etcd stores are passed to the API. Which one is given preference?

1

When multiple etcd stores are passed to the `libkv` API. Which one is given preference? - Round robin - First available one in the list - Or randomly one of...

djain13

Hello, The README.md and LICENSE.docs files are inconsistent about which license applies to the libkv documentation. The README.md file says that docs are: "...licensed under the _Creative Commons Attribution 4.0...

swinslow

Optionally disable the output from the underlying `go-zookeeper` library. E.g.: ``` 2018/01/09 13:09:35 Connected to [::1]:2181 2018/01/09 13:09:35 Authenticated: id=99320884360249348, timeout=10000 2018/01/09 13:09:35 Re-submitting `0` credentials after reconnect ```

jamiealquiza

like done for the Get method set the same options also for List (the same is already done for the etcd v2 backend). Signed-off-by: Simone Gotti

sgotti

AutoSync should never be broken,if so when one etcd cluster node change endpoint ip address then docker client will never known.

ringtail

In etcd at least, waitLock() ignores an action

1

In etcd at least, `waitLock()`, in [checking for an action to send "free" on](https://github.com/docker/libkv/blob/master/store/etcd/etcd.go#L578), does not account for `compareAndDelete` action which is what results from a [Delete with a modified...

debedb

can not get lock after release.

2

I write a simple program to test locker. I found `locker2` can not get lock after `locker1` `Unlock`. ``` func main() { stopChan1 := make(chan struct{}) stopChan2 := make(chan struct{})...

xiaoyulei

A race is possible in etcd's Lock()

1

Consider [line 499](https://github.com/docker/libkv/blob/master/store/etcd/etcd.go#L499): `l.last, err = l.client.Set(context.Background(), l.key, l.value, setOpts)` It is possible for `Set()` to succeed, and immediately the following call to `Set()` from a different goroutine to fail...

debedb

specify the default http.transport

1

Signed-off-by: lwh Although updating the consul code can avoid this problem, I think that it's necessary to specify the default transport when the code have used the ```http.DefaultClient```

lwhile