libkv
libkv copied to clipboard
Published
20 hours ago •
docker
docker
Add support for memo backend.
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "memo-backend" [email protected]:infinit/libkv.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Hi @mnottale.
Could you add some tests, like the other backends please (e.g. zookeeper_test, etcd_test, etc.).
Hi @mnottale.
seems good but could you create different PRs for each separate problems you fixed, because:
- only 5 commits are related to memo integration in libkv (https://github.com/docker/libkv/pull/172/commits/15fd92edcc959d2910d9828cfc56eb79a0a2d4f0, https://github.com/docker/libkv/pull/172/commits/5d43b1ebb3a921fdb945a5a4b78983ec7fe3b444, https://github.com/docker/libkv/pull/172/commits/2cc474585442a9415ce0d5b23dd995b2a187e806, https://github.com/docker/libkv/pull/172/commits/a7a9e2c89be14b0af3b3d6f780d92907cd3b8fda, https://github.com/docker/libkv/pull/172/commits/79fed48b9c8349db8f02c76430050cd23fd46ca4)
- 2 are related to the good health of the test suite (https://github.com/docker/libkv/pull/172/commits/6fa608e104e2b6c70c5c7fa7a909acb62417a9a4, https://github.com/docker/libkv/pull/172/commits/18a27596fcd8a964629961837466dcf9eb4761f6)
- the 3 lasts change travis configuration (https://github.com/docker/libkv/pull/172/commits/3a5aafde828610677afd5917eff3e6e0295eba14, https://github.com/docker/libkv/pull/172/commits/10523b13b5a5ce1acdecbdc16dd04323fec88696, https://github.com/docker/libkv/pull/172/commits/14f82150632a9f2ac443b83d409038cd1f844af4)