libcompose icon indicating copy to clipboard operation
libcompose copied to clipboard

`libcompose-cli rm` log messages are confusing.

Open kunalkushwaha opened this issue 10 years ago • 4 comments

In log message for libcompose-cli rm, before asking for deletion, it prints containers deleting message.

$ libcompose-cli rm
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose)
INFO[0000] [0/2] [web]: Deleting
INFO[0000] [0/2] [redis]: Deleting
INFO[0000] [0/2] [redis]: Deleted
Going to remove a40d47f53646656412a6a9162d0c4c6cfc2af66e52ed5550b820976c51d9997c, 2fbc01d5bfc23d7bd8467b113fa44f357e7998460121ce1c4513df316151dd70
Are you sure? [yN]
INFO[0000] [0/2] [web]: Deleted
y
INFO[0001] Project [sample]: Deleting project
INFO[0001] [0/2] [web]: Deleting
INFO[0001] [0/2] [redis]: Deleting
INFO[0001] [0/2] [redis]: Deleted
INFO[0001] [0/2] [web]: Deleted
INFO[0001] Project [sample]: Project deleted

Should be equivalent to

$ docker-compose rm
Going to remove sample_web_3, sample_web_2, sample_web_1, sample_redis_1
Are you sure? [yN] y
Removing sample_web_3 ... done
Removing sample_web_2 ... done
Removing sample_web_1 ... done
Removing sample_redis_1 ... done

kunalkushwaha avatar Feb 19 '16 08:02 kunalkushwaha

Thanks @kunalkushwaha, the output will change a bit soon :wink: to be closer to the docker-compose one, but I added this to 0.2.0 milestone.

vdemeester avatar Feb 19 '16 08:02 vdemeester

I will be happy to make PR, if no one is working on this.

kunalkushwaha avatar Feb 19 '16 08:02 kunalkushwaha

@kunalkushwaha The idea is stated in the roadmap : https://github.com/docker/libcompose/wiki/0.2.0-Milestone-Project-Page ; and the idea is to update the output when doing that :wink:.

Revamp docker cli internal using spf13/cobra and more inline with docker-compose

vdemeester avatar Feb 19 '16 09:02 vdemeester

The idea here would be to add the "remove …" log messages (and make the event in another log level).

Removing sample_web_3 ... done
Removing sample_web_2 ... done
Removing sample_web_1 ... done
Removing sample_redis_1 ... done

vdemeester avatar Jul 11 '16 10:07 vdemeester