kitematic
kitematic copied to clipboard

Published 20 hours ago •

Reame
Issues

Add custom volumes as an option

Open aaomidi opened this issue 6 years ago • 23 comments

#1923 #4399

These issues were closed with no resolution. I decided to go ahead and make these changes.

The code changes how the volume section is handled to be the same as the environment variables. Allow custom volumes and deleting of any existing volumes.

This PR can be further extended to ensure that if a volume change broke Docker, it can revert back to a cached list of mounts.

Dec 17 '18 18:12 aaomidi

Minor UI changes to make this work:

Dec 17 '18 18:12 aaomidi

Hey @jdrouet can you take a look at this PR?

Dec 20 '18 07:12 aaomidi

Is this feature forgotten?

Jan 15 '19 23:01 Marahin

@Marahin I'm ready here to provide any updates to get this into kitematic. Unfortunately the contributors are showing bad faith by simply ignoring it.

Jan 16 '19 00:01 aaomidi

I just wanted to drop-in and say thank you @jdrouet for finding time to check this out, it's something I'm looking forward to see in Kitematic. 👍

Jan 16 '19 09:01 Marahin

Thank you @jdrouet!

Jan 16 '19 19:01 aaomidi

Hey, is there any progress on reviewing this @jdrouet ? How can we help?

cc @stereokai

Feb 06 '19 15:02 benjamingr

Ship it! 🚀Please 👍

Feb 16 '19 19:02 Cyclic

come on, we need this feature in Kitematic

Mar 01 '19 15:03 Chrisdowson

@jdrouet so what's happening with this PR?

Mar 27 '19 11:03 stereokai

🙌

Mar 29 '19 16:03 Marahin

🎉

Apr 07 '19 01:04 ms3rgio

@aaomidi Your PR has been approved

Apr 08 '19 13:04 stereokai

@aaomidi @jdrouet This PR has been approved, what's blocking a release? Can we help in any way?

May 06 '19 11:05 stereokai

Nothing on my side unfortunately.

May 07 '19 03:05 aaomidi

What can be done to get this merged? What are the blockers?

Oct 18 '19 18:10 damianstasik

https://github.com/DockStation/dockstation fits the bill.

Jan 19 '20 01:01 moos

Bump - pls merge

Jan 21 '20 12:01 Hc747

What happened on releasing? It has been more than 1 year since the PR pushed !

Mar 03 '20 07:03 ash0080

So slow :/

Apr 01 '20 11:04 eried

If there is interest I'll push a release of the binaries to my fork...

Apr 01 '20 20:04 aaomidi

If there is interest I'll push a release of the binaries to my fork...

I instinctively checked your repo for releases but https://github.com/DockStation/dockstation was a nice workaround.

With this slow merging I would say everyone should ignore kitematic and support dockstation instead.

Apr 01 '20 21:04 eried

Yeah I don't think I want to be responsible for maintaining a fork of this :D

Apr 02 '20 03:04 aaomidi