kitematic icon indicating copy to clipboard operation
kitematic copied to clipboard

The only way to exit preferences is to click "go back"?

Open dlamblin opened this issue 6 years ago • 12 comments

Expected behavior

A cancel button, or clicking on some thing in the left side bar (the word containers)

Actual behavior

You appear stuck until you find the magic behavior link

Information about the Issue

Steps to reproduce the behavior

  1. ...
  2. ...

dlamblin avatar Mar 20 '18 11:03 dlamblin

back seems like a pretty normal way to do this - You do this every day on your phone, why does it need to be so much different on this app?

FrenchBen avatar Mar 20 '18 18:03 FrenchBen

Most dialogs over the last 30 years have their action buttons at the bottom right not some link on the top left. Also most left side bars would have some way of going home. There doesn't seem to be a way at least with a new install that has little content on the left. Eg if clicking the gear icon takes you into preferences, maybe clicking it when you're already there would take you back out.

dlamblin avatar Mar 21 '18 03:03 dlamblin

Think of it as a user test. If you sat someone who has never seen kitematic down and asked them to, for example, add a repo, watch their interaction. If they check if it's in the preferences find it's not, what do they do next to get back to the initial view? Is it natural and seamless? Edit: Github on mobile doesn't left me edit comments so I left a few. And they had some typos. Though you can switch to the desktop view.

dlamblin avatar Mar 21 '18 03:03 dlamblin

Specifically as to why is it not okay to make a desktop app that expects users to think of it as a phone app, but follows none of the style guides of iOS, Android, not to mention MacOS or Windows (metro?): There simply wasn't any indication of what to expect. The go back link iirc has no bread crumb call out, a left arrow, any icon, a different background color or a separator bar from the content itself. I cannot swipe in from the left for a hamburger icon menu, the static left sidebar is of no help in exiting preferences as it is anyway. I cannot swipe in from the bottom for a back button action. I'm not sure I expected to be able to swipe in any where, but I did attempt to scroll the content up down and left and right just in case I was missing some hidden overflowed content. That wasn't it either.

dlamblin avatar Mar 21 '18 03:03 dlamblin

Here's what it looked like at the time I entered the preferences. as-is Here's what I was thinking looking at that. thoughts after entering the preferences And here's what I was looking for, or expecting. I have some different mock ups, like if that link had been a button like the +New button is, though actually it's not my favorite and I'll spare you. buttons

dlamblin avatar Mar 25 '18 02:03 dlamblin

@dlamblin thank you for the detailed shots and pointers. I propose the following improvements:

  • Make the Gear Icon close the preference page if it was previously open
  • Make the Go Back link an actual button

Adding Cancel or Save would mean a complete change in behavior for this pref pane, which I don't have the resources for ATM.

WDYT?

FrenchBen avatar Mar 26 '18 17:03 FrenchBen

I think its a good incremental change set. The button would be a call to action and make the roll over more noticeable. The toggling of the gear is a logical thing I found myself attempting. One thing to note for that is that the menu item for preferences and the command-, (windows uses a hotkey too?) will need to either stay non-toggling, or update the text of the menu item once in preferences. Possibly to "Exit Preferences".

dlamblin avatar Mar 27 '18 02:03 dlamblin

@dlamblin would you be interested in making those changes?

FrenchBen avatar Mar 27 '18 22:03 FrenchBen

I think my work just booked the next few weekends for not prime time support work. I'll see when I can make time to do it.

dlamblin avatar Mar 28 '18 13:03 dlamblin

Hey @dlamblin, are you still working on this? If not, I'd like to work on this issue as my first PR.

shandheap avatar Jun 03 '18 14:06 shandheap