go-units
go-units copied to clipboard
docker
Use uint64 for parseSize
Functions like RAMInBytes offen used to parse memory
set to cgroup, while Linux kernel take cgroup memory
value as uint64, so we need the return value of
RAMInBytes also be uint64, otherwise we are not able
to set memory larger than MAX(int64) and smaller than
MAX(uint64).
This'll somewhat break compatibility since parseSize returns 0 when input is not parseable, but I doubt people actually depend on that because we already return error, so I don't think this'll be a problem.
Signed-off-by: Qiang Huang [email protected]
@dnephin Thanks for reviewing, I'm aware this'll break backward compatibility, as I said in commit log, I's a real bugfix, the bug impacts Docker and runc and all other projects which are using go-units, and I believe the backward compatibility break is very limited and acceptable.
Even that I noticed go-units is still 0.3.1, usually we don't have to guarantee backward compatibility before 1.0 right?
