go-plugins-helpers icon indicating copy to clipboard operation
go-plugins-helpers copied to clipboard

Add go.mod and go.sum pointing to currently working upstream builds

Open zgiles opened this issue 5 years ago • 5 comments

Opening this for consideration. It's challenging to use this repo as does not contain a go.mod/sum. With docker/docker not supporting semvers, one needs to usually manually override the dependencies in our projects. With these two files we can just use github.com/docker/go-plugins-helpers@latest and everything should work.

I'm not sure if these are the right versions to pin to, but they seem to work and compile; tests pass.

zgiles avatar Jan 23 '20 21:01 zgiles

We are hitting the same issue with this lib. I added it to go.mod. But I am getting the same error when running go mod vendor or go mod tidy:

github.com/elastic/beats/x-pack/dockerlogbeat imports
        github.com/docker/go-plugins-helpers/sdk imports
        github.com/coreos/go-systemd/activation: no matching versions for query "latest"

Please consider adding a go.mod file.

kvch avatar Feb 05 '20 16:02 kvch

hmm. I did add a go.mod file. I think ( am I right?? ) that the above error you gave actually show that go-systemd/activation doesnt have a go-mod? For example, when I use this library, I need to add it to my project as github.com/docker/go-plugin-helpers@master because latest means the highest vX.X number.. which docker things dont do. Yeah? But at least then this project has a go.mod and go.sum so this problem doesnt ripple down....

Yeah? Tell me if I'm wrong.. :)

zgiles avatar Feb 07 '20 04:02 zgiles

Sorry I was unclear. I would like the authors to consider merging your PR. :)

kvch avatar Feb 07 '20 08:02 kvch

Ah, thanks. :) me too. What do you think @thaJeztah

zgiles avatar Feb 07 '20 13:02 zgiles

Was there any progress on this recently?

mucamaca avatar Sep 28 '20 11:09 mucamaca