go-plugins-helpers
go-plugins-helpers copied to clipboard
Add go.mod and go.sum pointing to currently working upstream builds
Opening this for consideration. It's challenging to use this repo as does not contain a go.mod/sum. With docker/docker not supporting semvers, one needs to usually manually override the dependencies in our projects. With these two files we can just use github.com/docker/go-plugins-helpers@latest
and everything should work.
I'm not sure if these are the right versions to pin to, but they seem to work and compile; tests pass.
We are hitting the same issue with this lib. I added it to go.mod
. But I am getting the same error when running go mod vendor
or go mod tidy
:
github.com/elastic/beats/x-pack/dockerlogbeat imports
github.com/docker/go-plugins-helpers/sdk imports
github.com/coreos/go-systemd/activation: no matching versions for query "latest"
Please consider adding a go.mod
file.
hmm. I did add a go.mod
file. I think ( am I right?? ) that the above error you gave actually show that go-systemd/activation
doesnt have a go-mod?
For example, when I use this library, I need to add it to my project as github.com/docker/go-plugin-helpers@master
because latest
means the highest vX.X
number.. which docker things dont do. Yeah?
But at least then this project has a go.mod
and go.sum
so this problem doesnt ripple down....
Yeah? Tell me if I'm wrong.. :)
Sorry I was unclear. I would like the authors to consider merging your PR. :)
Ah, thanks. :) me too. What do you think @thaJeztah
Was there any progress on this recently?