go-connections icon indicating copy to clipboard operation
go-connections copied to clipboard

Overriding NextProtos can interfere with Application-Layer Protocol Negotiation or ALPN

Open jmacelroy opened this issue 3 years ago • 0 comments

If a server, such as grpc, is trying to set an app protocol and uses this lib for the socket then it will be overridden by https://github.com/docker/go-connections/blob/58542c764a1173ea3dac965d89146c931a2946f7/sockets/tcp_socket.go#L18.

This was probably unnoticed until go 1.17 when enforcement became strict https://golang.org/doc/go1.17#ALPN

jmacelroy avatar Oct 05 '21 18:10 jmacelroy