getting-started icon indicating copy to clipboard operation
getting-started copied to clipboard

Clarify phrasing in Part 9: Image-building best practices - Layer caching

Open johanperjulius1 opened this issue 3 years ago • 1 comments

Hi! I love the tutorial and I am almost at the end so thanks a lot! However, in part 9 I have a an issue with the instructions;

The first set of instructions in Layer caching reads as follow: 1. Update the Dockerfile to copy in the package.json first, install dependencies, and then copy everything else in.

What does this mean? Update the Dockerfile (with what?) in order to copy in the package.json file into the Dockerfile? Or should you copy in the Dockerfile into the package.json?

install dependencies? How?

Copy everything else in? What is everything else and from what file into what other?

I really don't mean to be rude, I just find the phrasing ambigous and think it could be simplified and clarified. :)

johanperjulius1 avatar Mar 11 '21 14:03 johanperjulius1

Hello! I wanted to follow up and ask if there is any feedback you could provide for my fix. Was it helpful, or is there anything else that could be improved? Thank you!

pmogan77 avatar Mar 02 '23 15:03 pmogan77