docs icon indicating copy to clipboard operation
docs copied to clipboard

Add examples, more documentation around health checks

Open thaJeztah opened this issue 7 years ago • 5 comments

Problem description

Healthchecks are a powerful feature, but the documentation is currently sparse. There is some basic information on its usage in the builder documentation, and the flags are included in the docker container run and docker service create command line reference, but no practical examples are included in the documentation.

Suggestions for a fix

Docker 17.05 and up adds additional options for health checks (start period), and I wrote a comment on that pull request to illustrate the functionality which may be useful as a starting point https://github.com/moby/moby/pull/28938#issuecomment-301736698, https://github.com/moby/moby/issues/35881#issuecomment-356619230, and I saw @tomwillfixit has a demo repository to show health checks (https://github.com/tomwillfixit/healthcheck).

Those examples are very basic, but can be useful in itself (possibly we may want to add a "real" example as well).

/cc @mstanleyjones

also /cc @dongluochen @tianon who may be able to provide more information on this subject 👍

thaJeztah avatar May 16 '17 11:05 thaJeztah

If I were to contribute some documentation, any recommendation on where that documentation should go? Since it appears, as you mentioned, in the builder, container run, and service create, should the healthchecks be their own page that each of those link to? Thoughts?

mikesir87 avatar Jan 20 '18 03:01 mikesir87

This would be a great contribution! As a first guess, I'd say that it should go under the "Run your app in production" top-level item in the TOC. As far as where to put it in the filesystem, /engine/admin/ might be a good home, for now. We can decide this in the PR at any time -- I can always commit with you and help you get it into the right place. Thanks!

mdlinville avatar Jan 23 '18 17:01 mdlinville

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!

ghost avatar Jan 02 '19 14:01 ghost

There hasn't been any activity on this issue for a long time. If the problem is still relevant, mark the issue as fresh with a /remove-lifecycle stale comment. If not, this issue will be closed in 14 days. This helps our maintainers focus on the active issues.

Prevent issues from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

docker-robot[bot] avatar Nov 23 '23 01:11 docker-robot[bot]

There hasn't been any activity on this issue for a long time. If the problem is still relevant, mark the issue as fresh with a /remove-lifecycle stale comment. If not, this issue will be closed in 14 days. This helps our maintainers focus on the active issues.

Prevent issues from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

docker-robot[bot] avatar May 13 '24 01:05 docker-robot[bot]