docs icon indicating copy to clipboard operation
docs copied to clipboard

ENGDOCS-1239

Open aevesdocker opened this issue 1 year ago • 5 comments

Description

As per https://github.com/docker/pinata/pull/28935

Related issues or tickets

Reviews

  • [x] Technical review (done via Slack
  • [ ] Editorial review
  • [ ] Product review

aevesdocker avatar Jun 25 '24 10:06 aevesdocker

Deploy Preview for docsdocker ready!

Name Link
Latest commit 82546660145c5e26db5ac1dddc6df59deefe25c0
Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/667aab5091c1d20008b2f607
Deploy Preview https://deploy-preview-20289--docsdocker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 25 '24 10:06 netlify[bot]

@aevesdocker can we defer merging this to 4.33 release please as an additional code change needed wasn't merged.

karman-docker avatar Jul 01 '24 10:07 karman-docker

@karman-docker, noted 👍

aevesdocker avatar Jul 01 '24 10:07 aevesdocker

Hi @aevesdocker , there has been some development since Monday and it was decided to include the additional change that I mentioned, in 4.32 release. So we can merge this once the 4.32 release is accounted. I do need to add one more detail to the docs via this PR, based on the additional fix that went in 4.32. I will update the details here once release has been announced. Thank you.

karman-docker avatar Jul 04 '24 13:07 karman-docker

Sounds good, thanks @karman-docker

aevesdocker avatar Jul 04 '24 13:07 aevesdocker

Let's create a follow-up PR @karman-docker with any additional changes. Release going out now

aevesdocker avatar Jul 04 '24 15:07 aevesdocker

sounds good @aevesdocker. Shall I create the PR or do you prefer I provide the details to be updated ?

karman-docker avatar Jul 04 '24 15:07 karman-docker

It'll be quicker if you create the PR 👍

aevesdocker avatar Jul 04 '24 15:07 aevesdocker