docs icon indicating copy to clipboard operation
docs copied to clipboard

ci: UPSTREAM_COMMIT was never declared as a variable in bake

Open dvdksn opened this issue 1 year ago • 1 comments

Signed-off-by: David Karlsson [email protected]

Description

The validate-upstream workflow uses UPSTREAM_COMMIT to define which Git commit to use for a temporary vendor of upstream doc files.

https://github.com/docker/docs/blob/main/Dockerfile#L64-L65

But due to a typo in the Bake file, UPSTREAM_MODULE_NAME is defined as a variable twice, and `UPSTREAM_COM is never defined as a variable:

https://github.com/docker/docs/blob/main/docker-bake.hcl#L152-L160

I don't know how validate-upstream has successfully ran before. We don't set the commit version as a build-arg, we use ENV. I thought that meant we need to declare a null variable in the bake file. Maybe it works anyway. But this is "more correct" anyway.

dvdksn avatar Feb 29 '24 09:02 dvdksn

Deploy Preview for docsdocker ready!

Name Link
Latest commit 1b0297d0b274b7329a41cddd065d8a777b6bb3b8
Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/65e0497b4778f900086b54ed
Deploy Preview https://deploy-preview-19536--docsdocker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 29 '24 09:02 netlify[bot]