docs icon indicating copy to clipboard operation
docs copied to clipboard

add --rm to docker run line

Open Habbie opened this issue 1 year ago • 7 comments

Proposed changes

Add --rm to the example docker run hello-world calls in the docs.

This would avoid leaving a (stopped) container lying around, as can be seen in docker ps -a.

I believe that, if you agree, multiple pages would want this change. Let me know and I'll push more commits (and I'm happy to squash afterwards).

Related issues (optional)

Habbie avatar Feb 06 '24 19:02 Habbie

Deploy Preview for docsdocker ready!

Name Link
Latest commit ab334febbefb4163d4ce71c528fb3df62c05b479
Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6702f309d0c75d00081aafad
Deploy Preview https://deploy-preview-19321--docsdocker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 06 '24 19:02 netlify[bot]

I don't think this change is necessary. hello-world is very small, a few KB in size (excluding Windows).

dvdksn avatar Feb 06 '24 19:02 dvdksn

I don't think this change is necessary. hello-world is very small, a few KB in size (excluding Windows).

It is 13.3kB on my system. run --rm does not recover those, and that was not the point of the PR. I trust a user will prune at some point and recover that space - which also does not seem important. I like my ps -a to cover things I wanted to have running.

Habbie avatar Feb 06 '24 19:02 Habbie

For what it's worth, I like the PR. The hello-world container is a simple test and only has temporary use; therefore it should leave no trace after it's done.

stephan-henningsen avatar Feb 06 '24 19:02 stephan-henningsen

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment. If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

docker-robot[bot] avatar May 06 '24 01:05 docker-robot[bot]

/remove-lifecycle stale

Habbie avatar May 06 '24 07:05 Habbie

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment. If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

docker-robot[bot] avatar Sep 11 '24 01:09 docker-robot[bot]