docs icon indicating copy to clipboard operation
docs copied to clipboard

jekyll: set liquid error mode to strict

Open crazy-max opened this issue 3 years ago • 1 comments

While working on another PR I found out there are liquid warnings introduced by https://github.com/docker/docker.github.io/pull/15494 in the logs: https://github.com/docker/docker.github.io/runs/8288660605?check_suite_focus=true#step:4:491

#15 44.17     Liquid Warning: Liquid syntax error (line 59): Expected end_of_string but found id in "{{if eq .Name "compose"}}" in compose/install/uninstall.md
#15 44.17     Liquid Warning: Liquid syntax error (line 59): [:dot, "."] is not a valid expression in "{{.Path}}" in compose/install/uninstall.md

Looking at this page https://docs.docker.com/compose/install/uninstall/#inspect-the-location-of-the-compose-cli-plugin, format is indeed broken:

image

To avoid this kind of issues in the future, sets Liquid error mode to strict.

Also got the following issue while enabling new error mode for Liquid:

#16 17.79   Liquid Exception: Liquid syntax error (/src/_includes/cli.md line 136): Unexpected character \ in "{{'[],map[],false,0,0s,default,\'\',""' | split: ',' }}" in engine/reference/commandline/app.md
#16 17.79                     ------------------------------------------------
#16 17.79       Jekyll 4.2.2   Please append `--trace` to the `build` command
#16 17.79                      for any additional information or backtrace.
#16 17.79                     ------------------------------------------------

This is fixed with last commit by using capture instead of assign.

crazy-max avatar Sep 11 '22 11:09 crazy-max

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
Latest commit aad35fe6d971990439fbb7027d73fc1b5c1fb754
Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6332ebeb05a2060008bfec47
Deploy Preview https://deploy-preview-15622--docsdocker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Sep 11 '22 11:09 netlify[bot]

Deploy Preview for docsdocker ready!

Name Link
Latest commit a9981de12fb328895abd2e8087b736db987ec00e
Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/635f77566d75320008df12e2
Deploy Preview https://deploy-preview-15622--docsdocker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 31 '22 07:10 netlify[bot]