docs icon indicating copy to clipboard operation
docs copied to clipboard

Fix port number in Getting Started images

Open danBamikiya opened this issue 3 years ago • 4 comments

Proposed changes

This pull request #14248 used port 8000 the examples in the compose/gettingstarted page but the images are still using port 5000 so I switched the images to ones using port 8000.

Unreleased project version (optional)

Related issues (optional)

danBamikiya avatar Feb 11 '22 12:02 danBamikiya

@StefanScherer Hi, I was observing the changes and noticed the images still used port 5000 which will be confusing for readers, here's a PR that switches the images to ones using port 8000, is this okay (I tried to make the images as similar as I could)?

danBamikiya avatar Feb 11 '22 12:02 danBamikiya

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: 7943277bd52ccf7cbf78f60e2c7f233d491067d2

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/6213dcd32310b90008450399

😎 Browse the preview: https://deploy-preview-14256--docsdocker.netlify.app

netlify[bot] avatar Feb 11 '22 12:02 netlify[bot]

Thanks @danBamikiya! Yes, that's a good catch. Of course the screen shots should display port 8000. Could I ask you if you can provide screenshots with a drop shadow similar to the old ones? Thanks.

StefanScherer avatar Feb 11 '22 15:02 StefanScherer

Thanks @danBamikiya! Yes, that's a good catch. Of course the screen shots should display port 8000. Could I ask you if you can provide screenshots with a drop shadow similar to the old ones? Thanks.

Hi @StefanScherer sorry for the late response. I've made the requested changes using Figma & I'll love for your review incase there's anymore changes I can make. Thanks!

danBamikiya avatar Feb 21 '22 18:02 danBamikiya

@usha-mandya You're welcome! :)

danBamikiya avatar Sep 30 '22 16:09 danBamikiya