Minimal changes to trust/trust_sandbox docs
Proposed changes
The current Docker Content Trust sandbox documentation "Play in a content trust sandbox" is WAY out of date.
There have been some PRs that address this problem, like PR#10078, but I felt like they were adding too much complexity to the system, or they were not working at all.
Here I propose a minimal amount of changes needed for the documentation to still be relevant, without any major changes to the page's content.
Related issues
Fixes #12192 Fixes #11539
Feedback is nevertheless much appreciated!
Deploy Preview for docsdocker ready!
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | b09d743bdec77abca8b32e5b0a47a346fbda6acf |
| Latest deploy log | https://app.netlify.com/sites/docsdocker/deploys/6305ecbc25a99000095c3686 |
| Deploy Preview | https://deploy-preview-13912--docsdocker.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Thank you for this proposal, it was helpful for massaging the documented trust sandbox environment to a workable state. I have a couple points of feedback:
- It looks like
bashisn't available in the laterregistry:2.7images, probably need suggest the sameshin the exec againstsandboxregistryas is done fortrustsandbox. (ref: step 2 of Test with malicious images) - I don't think we need the port publishes added, as the guide is designed to be conducted from within
trustsandbox.
Thank you @thirdgen88 for the answer!
- It looks like
bashisn't available in the laterregistry:2.7images, probably need suggest the sameshin the exec againstsandboxregistryas is done fortrustsandbox. (ref: step 2 of Test with malicious images)- I don't think we need the port publishes added, as the guide is designed to be conducted from within
trustsandbox.
True! I will change these in a future commit. Thanks!
@thaJeztah Could you PTAL?
Close and reopen the PR to trigger CI checks
Any updates on the pr status?
@IAL32 Thank you ! You can also remove the port mapping for the server service (4443:4443)
Also the following command (here)
docker container exec -it sandboxregistry bash
should be :
docker container exec -it sandboxregistry sh
@matletix I have addressed these issues now π
Deploy Preview for docsdocker ready!
| Name | Link |
|---|---|
| Latest commit | ff6e04a6cdd074f2676a350dfae03d2800d16b1d |
| Latest deploy log | https://app.netlify.com/sites/docsdocker/deploys/638733bdd546a70009f79902 |
| Deploy Preview | https://deploy-preview-13912--docsdocker.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Looks like I started a review a long time ago, but never submitted (I may have been looking at the technical side of Notary); let me submit the review, but have a look if all comments (still) make sense π
I have implemented many of the changes from @thaJeztah , thanks! I have also updated some of the outputs.
let me know! π
Thanks for the pull request. We'd like to make our product docs better, but havenβt been able to review all the suggestions. As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.
If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.
Prevent pull requests from auto-closing with a /lifecycle frozen comment.
/lifecycle stale
/remove-lifecycle stale
@thaJeztah could you PTAL?
Any updates? Belated happy 1 year for my PR π₯³ @thaJeztah @usha-mandya @glours
I guess the malicious image section could still be useful in some form or another, but it's mostly to illustrate that Docker verifies the content when pulling (if the content's digest doesn't match it would reject the image)
Thanks for the pull request. We'd like to make our product docs better, but havenβt been able to review all the suggestions. As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.
If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.
Prevent pull requests from auto-closing with a /lifecycle frozen comment.
/lifecycle stale