docs icon indicating copy to clipboard operation
docs copied to clipboard

WIP rewrite section on configuring proxies for containers

Open thaJeztah opened this issue 4 years ago β€’ 4 comments
trafficstars

Signed-off-by: Sebastiaan van Stijn [email protected]

Proposed changes

Unreleased project version (optional)

Related issues (optional)

thaJeztah avatar Nov 04 '21 10:11 thaJeztah

Just pushing this as a draft; this is very unfinished (need to rewrite the last section and also mention upper/lowercase etc)

thaJeztah avatar Nov 04 '21 10:11 thaJeztah

βœ”οΈ Deploy Preview for docsdocker ready!

πŸ”¨ Explore the source changes: c07a1dc055bb5a98b3f9c955b0856d35652b2b32

πŸ” Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/6183bb41ca9524000751e914

😎 Browse the preview: https://deploy-preview-13786--docsdocker.netlify.app

netlify[bot] avatar Nov 04 '21 10:11 netlify[bot]

I need to collect more changes and put them together, e.g. https://github.com/docker/docker.github.io/pull/8352 and https://github.com/docker/docker.github.io/pull/12463 (which also isn't correct, as "it depends")

And describe that handling of NO_PROXY is quite different (depending on what software uses it), same as for upper/lowercase cURL, wget, and Golang don't agree on those.

thaJeztah avatar Nov 04 '21 12:11 thaJeztah

@thaJeztah Is this PR still relevant? Thanks.

usha-mandya avatar Aug 10 '22 09:08 usha-mandya

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment. If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

docker-robott avatar Nov 26 '22 01:11 docker-robott

Reopening for now (still in draft), but still something to finish.

thaJeztah avatar Apr 13 '23 11:04 thaJeztah

Deploy Preview for docsdocker ready!

Name Link
Latest commit 073cd2fe24f54ae0e6a31238966369e8ed075ce4
Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6452a1be955eb400084b5bab
Deploy Preview https://deploy-preview-13786--docsdocker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Apr 13 '23 11:04 netlify[bot]

@thaJeztah I continued on some of the changes you started in this PR. PTAL and let me know if there's more stuff that we should add/change in the scope of this

dvdksn avatar Apr 27 '23 13:04 dvdksn

Oh! Thanks, sorry forgot about this one; gonna give this one a look Today.

I see there's one link failure; perhaps we need a custom id / anchor somewhere;

========================================================================
engine/reference/commandline/cli/index.html
  hash does not exist --- engine/reference/commandline/cli/index.html --> /config/daemon/systemd/#httphttps-proxy
engine/reference/commandline/dockerd/index.html
  hash does not exist --- engine/reference/commandline/dockerd/index.html --> /config/daemon/systemd/#httphttps-proxy
========================================================================

thaJeztah avatar May 03 '23 08:05 thaJeztah

Fixed the broken link upstream in docker/cli#4249 - will need to backport that one

dvdksn avatar May 03 '23 11:05 dvdksn