docs icon indicating copy to clipboard operation
docs copied to clipboard

Typo fixes

Open MicaelJarniac opened this issue 4 years ago • 4 comments

Proposed changes

Mostly typo fixes.

MicaelJarniac avatar Jul 03 '21 15:07 MicaelJarniac

:heavy_check_mark: Deploy Preview for docsdocker ready!

:hammer: Explore the source changes: 56406a832f3b552387db0a3cbaa12d91f7a9a316

:mag: Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/60e087de942aae00077e35ee

:sunglasses: Browse the preview: https://deploy-preview-13113--docsdocker.netlify.app

netlify[bot] avatar Jul 03 '21 15:07 netlify[bot]

:heavy_check_mark: Deploy Preview for docsdocker ready!

:hammer: Explore the source changes: 1d85c1b5994bd72b1a67043955f64bba02c4a0ed

:mag: Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/60e088261ef4a7000778051d

:sunglasses: Browse the preview: https://deploy-preview-13113--docsdocker.netlify.app

netlify[bot] avatar Jul 03 '21 16:07 netlify[bot]

To give a bit of context, I've opened this PR as a draft because I haven't quite finished reading the docs yet, so I might add more fixes to it.

Instead of submitting a PR per change, I decided it'd be better to condense them all into a single PR.

And although I could wait to open this PR after I'm done reading the docs, I thought it'd be safer to open it as a draft earlier, so if I end up completely forgetting about it, at least it's already here.

MicaelJarniac avatar Jul 07 '21 18:07 MicaelJarniac

@MicaelJarniac Could you rebase the PR?

usha-mandya avatar Sep 30 '22 10:09 usha-mandya

~~@usha-mandya part of the changes was in a section that seems to have been replaced by a {% include guides/create-dockerfile.md %}. I cannot seem to figure out where that's pointing, in order to rebase.~~

Nevermind, just found it, it's under _includes, which I suppose makes sense. Am rebasing.

MicaelJarniac avatar Oct 17 '22 22:10 MicaelJarniac

Deploy Preview for docsdocker ready!

Name Link
Latest commit 7def38c68e292a241535625c5b8f549d50a4b388
Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/634dd8470f75940008c09a5a
Deploy Preview https://deploy-preview-13113--docsdocker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 17 '22 22:10 netlify[bot]

Okay, I think I've rebased it wrong.

MicaelJarniac avatar Oct 17 '22 22:10 MicaelJarniac

I have absolutely no idea what went so wrong.

MicaelJarniac avatar Oct 17 '22 22:10 MicaelJarniac

If you compare manually between my branch and master here, it says there are only 20 commits and 3 files changed. No idea why this PR shows thousands of files changed.

https://github.com/docker/docs/compare/master...MicaelJarniac:docker.github.io:patch-1

MicaelJarniac avatar Oct 17 '22 22:10 MicaelJarniac

I'm terribly sorry for all the confusion and the hundreds of people I probably just angered.

I've never rebased before, and I still don't know what went wrong, but something did, and chaos ensued.

I opened another PR, #15895, and this time it seems to have worked fine. That PR was created from the exact same branch this one was from, and I did nothing else to fix it other than to close this PR and open the new one, so whatever went wrong with this PR is a mystery to me.

Again, I'm sorry for the mess.

MicaelJarniac avatar Oct 18 '22 04:10 MicaelJarniac

No worries @MicaelJarniac, we all get lost in Git hell sometimes 😄 Thanks for helping out!

dvdksn avatar Oct 18 '22 07:10 dvdksn