docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

Add support for Docker network EnableIPv4 option with API 1.48

Open Dramelac opened this issue 4 months ago • 7 comments

Adding support for EnableIPv4 for docker network with API 1.48 (source: https://docs.docker.com/reference/api/engine/version-history/#v148-api-changes)

Equivalent to the command option docker network create --ipv4

Dramelac avatar Aug 14 '25 22:08 Dramelac

I've force pushed to comply with Signed-off-by commit message. Is everything ok with the PR ? I saw some errors with the workflows but I'm not sure it's related to my changes.

Dramelac avatar Aug 18 '25 12:08 Dramelac

I updated the test, and I also updated the version of Docker to use in order to use the minimum API version for the new feature. While I was at it, I took the opportunity to update the new syntax for .utcfromtimestamp(), which had been deprecated.

Dramelac avatar Aug 19 '25 10:08 Dramelac

Is everything OK for you with this PR ?

(If a fix for dind-ssl tests is available, I can merge it in the PR)

Dramelac avatar Aug 19 '25 18:08 Dramelac

Ok I've found a fix for the SSL tests. Everything should work now. Let me know if you want me to create a dedicated PR for this fix.

Dramelac avatar Aug 19 '25 21:08 Dramelac

Do you want me to split this PR to separate the new feature and the bug fixes (and the SSL test) or do you prefer merging this PR all-in-one ?

Dramelac avatar Aug 25 '25 10:08 Dramelac

Can someone run the test ? This PR should be ready to merge

Dramelac avatar Oct 13 '25 17:10 Dramelac

Is something missing with this PR ?

Dramelac avatar Nov 18 '25 14:11 Dramelac