docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

ResourceWarning: unclosed <socket.socket> [still occuring]

Open kasium opened this issue 1 year ago • 2 comments

I can still see the resource warning from https://github.com/docker/docker-py/issues/1293 in some cases:

pytest.PytestUnraisableExceptionWarning: Exception ignored in: <socket.socket fd=-1, family=1, type=1, proto=0>

Traceback (most recent call last):
  File "<frozen _collections_abc>", line 435, in __subclasshook__
ResourceWarning: unclosed <socket.socket fd=41, family=1, type=1, proto=0, raddr=/var/run/docker.sock>

I use python 3.12 and docker-py 7.1.

I guess that the close method of BaseHTTPAdapter in docker/transport/basehttpadapter.py should call close on the pool rather than clear

kasium avatar Jun 03 '24 11:06 kasium

I'm not able to reproduce the warning. Also, Calling clear closes all urllib3.poolmanager.PoolManager instance so no issue here

Khushiyant avatar Jun 17 '24 08:06 Khushiyant

Maybe it's worth to mention that I use 1.26.18

kasium avatar Jun 17 '24 13:06 kasium