docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

Add GPUs parameter

Open ryanleary opened this issue 6 years ago • 4 comments

Aim is to be backwards compatible with API < 1.40 while only requiring gpus kwargs be used. Thanks to @sigurdkb for original implementation.

ryanleary avatar Nov 18 '19 17:11 ryanleary

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "gpus_parameter" [email protected]:ryanleary/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354320816
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Nov 18 '19 17:11 GordonTheTurtle

Any Updates on the failed style checks?

eugland avatar Dec 02 '19 15:12 eugland

@ryanleary Any update on this? If the issue is just formatting, it would be nice to unblock this and help https://github.com/docker/compose/issues/6691

xkortex avatar Aug 24 '20 19:08 xkortex

@xkortex does it need to be since #2471 has been merged?

ghost avatar Aug 24 '20 23:08 ghost