docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

Add empheral dockerfile handling

Open majkrzak opened this issue 6 years ago • 6 comments

close #2105 according to https://github.com/docker/docker-py/issues/2105#issuecomment-411154477

majkrzak avatar Nov 05 '19 16:11 majkrzak

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" [email protected]:majkrzak/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Nov 05 '19 16:11 GordonTheTurtle

:man_facepalming:

majkrzak avatar Nov 05 '19 16:11 majkrzak

:wave: are you fine down there? :wave:

majkrzak avatar Feb 09 '20 12:02 majkrzak

:wave:

majkrzak avatar Jun 26 '20 13:06 majkrzak

I wonder if this PR will get merged faster than https://github.com/gkoberger/stacksort/pull/4

majkrzak avatar Jan 19 '21 17:01 majkrzak

Hello @majkrzak. I think that trying to detect if it's the content or not is not an accurate way. For example, this is a valid Dockerfile content AND a filename

FROM ubuntu

IMO another parameter with the content would be better

ulyssessouza avatar Feb 09 '21 17:02 ulyssessouza