docker-py icon indicating copy to clipboard operation
docker-py copied to clipboard

Add mac_address to connect_container_to_network

Open hongbin opened this issue 7 years ago • 5 comments

hongbin avatar Sep 24 '17 18:09 hongbin

Thanks! Do you mind adding the appropriate version check?

shin- avatar Sep 26 '17 19:09 shin-

@shin- Done

hongbin avatar Sep 28 '17 20:09 hongbin

I tried adding a test for this, but I don't think this is supported by the engine yet as no matter what I do, I'm not able to set a different MAC address for the network. This is reinforced by the fact that there is currently no CLI option to achieve this: https://github.com/moby/moby/issues/33715

Until this actually works with the Docker Engine, I think we probably shouldn't merge this PR.

shin- avatar Nov 07 '17 02:11 shin-

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "connect-with-mac" [email protected]:hongbin/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354570992
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Jan 20 '19 05:01 GordonTheTurtle

@shin- when you said "I'm not able to set a different MAC address for the network", could you provide the exact reproducing steps? I will follow up with that.

hongbin avatar Jan 20 '19 05:01 hongbin