docker-install icon indicating copy to clipboard operation
docker-install copied to clipboard

add cool webpage for get.docker.com

Open duhruh opened this issue 5 years ago • 5 comments

Screen Shot 2019-07-11 at 2 54 53 PM

duhruh avatar Jul 11 '19 21:07 duhruh

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "feature/web-page" [email protected]:duhruh/docker-install.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Jul 11 '19 21:07 GordonTheTurtle

A recent change to shellcheck seems to have made SC2034 a little more strict.

https://github.com/koalaman/shellcheck/releases/tag/v0.6.0 released Dec 3, 2018 but the latest tag on https://hub.docker.com/r/koalaman/shellcheck/tags was pushed Jul 4, 2019.

nemchik avatar Jul 15 '19 18:07 nemchik

I also believe the ensubst might be the issue, you need to be selective on which vars are going to be substituted, for reference: https://unix.stackexchange.com/a/294400/249966

seemethere avatar Jul 15 '19 19:07 seemethere

@duhruh can you rebase now that #131 is merged in, should hopefully make getting this in a bit easier.

seemethere avatar Jul 15 '19 19:07 seemethere

Hmm, actually I like to have the code shown in browser. Easiest way to quickly search through code from desktop. One can copy&paste or "save to file" as well. Not sure about the benefit of having a website instead which just shows the same command line that you very likely got the URL itself from? 😉

MichaIng avatar Dec 09 '19 11:12 MichaIng