docker-credential-helpers icon indicating copy to clipboard operation
docker-credential-helpers copied to clipboard

Published 20 hours ago • verified publisher icon docker

Fixing the path in Building from scratch

Open viktorbenei opened this issue 6 years ago • 2 comments

viktorbenei avatar Jan 31 '19 17:01 viktorbenei

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" [email protected]:viktorbenei/docker-credential-helpers.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Jan 31 '19 17:01 GordonTheTurtle

Thanks for your PR! Can you rebase and sign your commit ?

Thanks!

guillaumerose avatar Apr 30 '19 07:04 guillaumerose

Thanks for contributing; this has been fixed in https://github.com/docker/docker-credential-helpers/pull/233

thaJeztah avatar Aug 21 '22 14:08 thaJeztah