docker-ce-packaging icon indicating copy to clipboard operation
docker-ce-packaging copied to clipboard
verified publisher icon docker

Patch for build with mock

Open eabdullin1 opened this issue 3 years ago • 5 comments

Hello! During the build of Docker, I encountered the fact that it cannot be built using a mock. Changes in the PR allow you to build not from under the user's root, as well as use a mock.

eabdullin1 avatar Jun 15 '22 08:06 eabdullin1

@rumpl Hello, can you please review this change?

eabdullin1 avatar Jun 21 '22 14:06 eabdullin1

@thaJeztah Maybe you can help?

eabdullin1 avatar Jul 04 '22 14:07 eabdullin1

I'm not sure if we should make these changes; all the scripts and specs in this repository are currently designed to be used as part of the Dockerfiles in this repository; IIUC, these changes would mean that the distro-provided golang would be installed (not the version as specified in the GO_IMAGE build-arg.

thaJeztah avatar Jul 04 '22 14:07 thaJeztah

Yes, with these changes will be used upstream version of golang from the current distro

eabdullin1 avatar Jul 04 '22 15:07 eabdullin1

Should we close this PR?

eabdullin1 avatar Jul 08 '22 14:07 eabdullin1