Refactor `StringContains` and `contains` function usages to use `go` ones

Open ulyssessouza opened this issue 3 years ago • 1 comments

What I did Refactor contains functions

Sep 22 '22 13:09 ulyssessouza

@glours I was thinking the same. But when I saw the implementation... I cannot think about something that would be change enough for our simple case. There is also a "k8s.io/utils/strings/slices" implementation for Contains. For me that's the same, since the idea of the PR is just not to have "yet another" implementation of a so common function.

Sep 22 '22 15:09 ulyssessouza

isn't "yet another (copy/paste) implementation for common function" the basis of Golang design ? kidding appart, shall we keep this PR open?

Apr 17 '23 12:04 ndeloof

I'll close it... It's still not extracted from the experimental package and all the files are conflicting... 😞

Apr 21 '23 13:04 ulyssessouza