compose icon indicating copy to clipboard operation
compose copied to clipboard

Use latest version of buildx

Open errordeveloper opened this issue 3 years ago • 5 comments

Description

Currently compose uses buildx 0.5.1, latest version is 0.7.1, an update is overdue.

errordeveloper avatar Jan 11 '22 15:01 errordeveloper

Right, we should keep buildx dependency up to date. In an ideal world we should not vendor buildx in compose, but delegate to buildx as installed by the docker CLI... cc @chris-crone

ndeloof avatar Jan 14 '22 08:01 ndeloof

I wonder: doesn't dependabot help us to address this?

ndeloof avatar Jan 14 '22 08:01 ndeloof

I wonder: doesn't dependabot help us to address this?

Not sure, I never used it much. One of the challenges is that buildx doesn't yet offer a simple and stable API. I would prefer to make the API better, but it sounds like we might go with the plugin option for now.

errordeveloper avatar Jan 14 '22 08:01 errordeveloper

Right, we should keep buildx dependency up to date. In an ideal world we should not vendor buildx in compose, but delegate to buildx as installed by the docker CLI... cc @chris-crone

Yes, the decision was to use buildx as a plugin for now. I think the real justification is that currently the complex dependency tries are tricky to overlap. In my ideal view we should simplify build client library (perhaps by decoupling from the CLI as such), but I don't see a way we could prioritise it now. We do have a fairly good plugin framework, so it's not going to be a plain exec.

errordeveloper avatar Jan 14 '22 08:01 errordeveloper

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 02:07 stale[bot]

This issue has been automatically closed because it had not recent activity during the stale period.

stale[bot] avatar Nov 02 '22 03:11 stale[bot]