introduce config --images-to-build

[abdennour]

What I did Ability to filter images by services which uses built images implement proposal of #8994 , exactly, option 1

Related issue

#8994

(not mandatory) A picture of a cute animal, if possible in relation with what you did

[abdennour]

@ndeloof

First-time contributors need a maintainer to approve running workflows. please help to approve @ndeloof @glours

[ndeloof]

code looks good, but I'm not fan for adding an option that only applies to the --config pseudo-command (which should be a subcommand), as this would be confusing and not apply to other (pseudo-)commands. Maybe time to introduce compose config images as a real subcommand which could define it's own options?

[abdennour]

Scenario 2 requires a lot of development @glours . For the time being, it can combine only with --images

1. Should i revert to Scenario 1 since it's very specific (--built-images) ?
2. Or Should i proceed with Scenario (2) by finishing the combination with other flags one by one ?
3. Or go with new scenario propose by @ndeloof above (docker compose config images ) ?

@glours @ndeloof any team decision, so i can proceed?

[ndeloof]

A possible issue with my proposed solution is that compose config accept a list of services as arguments, and introducing sub-commands would conflict with this usage or forbid use of some reserved names as services :'(

No strong opinion yet on the best approach, need to think twice about it

[abdennour]

Yep! @ndeloof , Think about --only-built as adjective for services , as global option. that time, filtering will happen at the level of project.Services or project.WithServices Does it make sense!

[ndeloof]

Got it, make sense.

[abdennour]

Also, @ndeloof we can go agile : releasing config --built-images , then think about refactoring/re-organizing.

[abdennour]

@ndeloof @glours , since adding new flag depends on --images flag requires redesign, i just pushed now the option (1) which is a new flag without dependency to others

docker compose config --built-images

I would suggest to accept this feature as incremental release , and with motivation to go AGILE. Later on, we can think about refactoring this subcommand , indeed, you have already --resolve-image-disgests, which should belong to subsubcommand images since long time

[glours]

@abdennour

I don't think we should accept this incremental step and I'll explain why Compose is a wildy used project, if we introduce a new command or a new flag this new feature will be quickly used to script some bots or used in CI flows and then we'll be block (or it'll a least been painful) to remove this "temporary" increment. This is typically the kind of behaviour which drive a project to feature overload.

I really prefer that we take few days to think to a proper solution instead of rushing.

If you're currently block by this missing option, maybe piping the json output format --format json with a jq filter can help you until we find the best option

[ndeloof]

I tend to agree. Agile != "let's add random stuff and change our mind any time", especially when it comes to UX. Once we introduce a new flag, it will be there forever.

[abdennour]

Totally agree @glours @ndeloof , this is INTERFACE design pattern & it should be stable by Design. BTW, i am not blocked @glours , as i forked it and i released the feature in the fork: https://github.com/ElmCompany/compose/releases/tag/v2.2.4

Nevertheless, i will be waiting for the final design in #8994 , so we can go with it, and i would be happy to resume the contribution. BTW, the software is lacking testing, let's work on it as well: May be capturing stdout for testing purposes will require extensive refactor from code perspective not functionality perspective.

[abdennour]

Reminder @ndeloof @glours

[abdennour]

@ndeloof @glours i made the change as per my comment here https://github.com/docker/compose/issues/8994#issuecomment-996905644 It should be acceptable now. Let me know if you need any change

[abdennour]

I really want to know if you need anything in order to approve/merge/release this PR. @ndeloof @glours Kind reminder !!

[abdennour]

@glours You are requested for review. @ndeloof who is the backup of @glours

[abdennour]

I really want to know if you need anything in order to approve/merge/release this PR. @ndeloof @glours Kind reminder !!

[glours]

Hello @abdennour

Sorry for the delay of the response. I still prefer the option of having a dedicated compose config images option mentioned by @ndeloof With the holidays period we didn't have time to talk about this option internally ATM. cc @ulyssessouza FYI