compose icon indicating copy to clipboard operation
compose copied to clipboard

Published 20 hours ago • verified publisher icon docker

Use logrus instead of direct output to stderr

Open felixfontein opened this issue 1 year ago • 1 comments

What I did There are two warnings on stderr that --progress json (#11478) still emits as plain text. This is because they are printed there directly, without using logrus or the events framework.

This PR changes these places to use logrus.Warnf(...) instead of fmt.Fprintf(s.stderr(), ...).

Related issue Ref: #11478 (not an issue, but a PR)

felixfontein avatar Jul 20 '24 14:07 felixfontein

@cmrigney @ndeloof you might also be interested in this PR since it avoids more free-form stderr text in case the JSON stream progress writer is used.

felixfontein avatar Jul 23 '24 15:07 felixfontein

@ndeloof any chance of getting this merged anytime soon?

felixfontein avatar Sep 10 '24 22:09 felixfontein

@ndeloof thanks for reviewing and merging!

felixfontein avatar Sep 11 '24 10:09 felixfontein