compose icon indicating copy to clipboard operation
compose copied to clipboard

Remove COMPOSE_MENU env from e2e tests

Open jhrotko opened this issue 1 year ago • 2 comments

What I did Removed COMPOSE_MENU from env in Dockerfile and Makefile Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did image

jhrotko avatar Mar 22 '24 20:03 jhrotko

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.76%. Comparing base (cc09f39) to head (4170c47). Report is 25 commits behind head on main.

:exclamation: Current head 4170c47 differs from pull request most recent head 769ec5a

Please upload reports for the commit 769ec5a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11654      +/-   ##
==========================================
+ Coverage   54.52%   54.76%   +0.23%     
==========================================
  Files         145      145              
  Lines       12694    12585     -109     
==========================================
- Hits         6922     6892      -30     
+ Misses       5071     4999      -72     
+ Partials      701      694       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 22 '24 21:03 codecov[bot]

if removal for COMPOSE_MENU require --menu=false to be added to all our e2e test I'd prefer we keep the variable!

ndeloof avatar Mar 26 '24 15:03 ndeloof