compose icon indicating copy to clipboard operation
compose copied to clipboard
verified publisher icon docker

update `RunWithStatus(...)` to respect custom writer attached by `WithContextWriter(...)`

Open tigerinus opened this issue 3 years ago • 3 comments

What I did

  • updated RunWithStatus(...) to respect custom writer if it is attached to the ctx passed in.
  • added passing unit tests
  • closes #10091

Related issue

  • #10091

tigerinus avatar Dec 19 '22 00:12 tigerinus

@ndeloof can u help me to understand about the failing e2e tests?

tigerinus avatar Dec 19 '22 10:12 tigerinus

@ndeloof - can you approve this one more time? I saw the other PR passed the e2e tests, so I wonder if the failed e2e tests here are due to the changes I made. Thanks!

tigerinus avatar Dec 19 '22 18:12 tigerinus

@ndeloof - I ran the e2e tests again, with and without my PR changes, both ran into the 15min timeout.

Could it be irrelevant but intermittent issue? Does it have to block the PR merge?

Thanks!

tigerinus avatar Dec 20 '22 23:12 tigerinus