docker
Add OomScoreAdj to "docker service create" and "docker compose"
- [x] depends on https://github.com/moby/moby/pull/47950
- [x] depends on https://github.com/docker/cli/pull/5169
- [x] depends on https://github.com/docker/cli/pull/5170
- What I did I added oom-score-adj flag to docker service create and docker service update
- How I did it By modifying container service to accept the option as well as adding a flag to the CLI
- How to test it Compile this PR and copy the CLI binary to a running moby dev shell using https://github.com/moby/moby/pull/47950
- Description for the changelog
Add OOMScoreAdj to docker service create and docker compose
Codecov Report
Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
Project coverage is 61.02%. Comparing base (
9bb1a62) to head (aa2c2cd). Report is 49 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #5145 +/- ##
==========================================
- Coverage 61.48% 61.02% -0.46%
==========================================
Files 298 296 -2
Lines 20811 20845 +34
==========================================
- Hits 12795 12721 -74
- Misses 7103 7207 +104
- Partials 913 917 +4
Is there something wrong with the validate/validate-md check? The diff in my PR doesn't show any of the changes that are reflected in the check. A git diff locally doesn't reflect any of those changes either.
Is there something wrong with the validate/validate-md check?
No.
https://github.com/docker/cli/blob/2f529a19651763d8fa43c31e47637aae65c0dd68/.github/workflows/validate.yml#L38-L57
The markdown files are generated from the Go sources. Following Go ecosystem convention, generated files are committed to the repo alongside their sources. The validate/validate-md check is asserting that the generated files are in sync.
Run make -f docker.Makefile mddocs locally and commit the result.
