cli icon indicating copy to clipboard operation
cli copied to clipboard

Remove OTEL stuff from "compose wrapper"

Open krissetto opened this issue 1 year ago • 0 comments

Description

Goal:

Moving the OTEL bits and bobs out of the "compose wrapper", consolidating the features into the CLI itself, so we can later axe 🪓 the whole wrapper once all it's functionality has been moved/replaced.

Stuff to do:

  • [x] Create basic OTEL infra the CLI project (#4889 creates some basic sdk abstractions to share);
  • [x] Move basic OTEL helpers from the wrapper to the CLI project and adapt/create what's necessary. Check here for some of the current impl
  • [x] Move necessary logic from reporter.go and client.go in the wrapper to the CLI (adapting what's necessary to otel) Check reporter.go and client.go
  • [x] Use the new common OTEL bits to instrument the CLI project itself, recreating CLI specific metrics/traces initially defined in the wrapper (check if carrying #4698 is worth it). Done via https://github.com/docker/cli/pull/4940
  • [ ] Adapt projs/plugins (eg compose, buildx, ...) to use the new shared code wherever possible
  • [ ] Remove otel bits from the wrapper (optional if we already merged #4376, since we can remove the whole wrapper)
  • [ ] Profit

krissetto avatar Mar 08 '24 11:03 krissetto