buildx icon indicating copy to clipboard operation
buildx copied to clipboard

Feature Request - Make manifest customizable for Kubernetes driver

Open diego-maravankin opened this issue 5 years ago • 6 comments

Hi guys! First of all, I'd like to thank you for this great tool, it makes it really easy for remote image building in a Kubernetes cluster.

It would be great if buildx allowed the user to customize the manifest used to generate the deployment. My main interests are:

  • resource limits, to avoid the situation where a build might affect other workloads in the kubernetes node. I am aware that this might lead to a build failure.
  • the possibility to add tolerations to the pods, so that I can taint a node to use it exclusively for image building (combinig the toleration with the currently supported nodeSelector configuration) and not affecting other workloads in the kubernetes node.

Thanks guys for this awesome tool!

Diego

diego-maravankin avatar Sep 01 '20 12:09 diego-maravankin

It would be especially helpful if there were a kubernetes driver opt for toleration(s) to coincide with the already available nodeselector option.

paulbsch avatar Oct 23 '20 07:10 paulbsch

+1 for this. Taint / toleration options are key, resource limits would be nice

zfalen-deloitte avatar Mar 30 '21 22:03 zfalen-deloitte

~Fixed by https://github.com/docker/buildx/pull/618~

crazy-max avatar Jun 29 '21 14:06 crazy-max

+1 Really this is very important, ti think a lot of people would appreciate it if you add this option

runcloudone avatar Jul 09 '21 12:07 runcloudone

That's very useful

therapy-lf avatar Sep 02 '21 12:09 therapy-lf

Would love it if we could get this!

ebdekock avatar Jan 12 '22 09:01 ebdekock