buildx icon indicating copy to clipboard operation
buildx copied to clipboard

bake: deprecate x-bake compose extension

Open crazy-max opened this issue 9 months ago • 4 comments

https://github.com/docker/buildx/pull/721 was introduced to allow the use of additional fields that were not supported by the official specification at the time. Now that the Compose specification for build is ahead, we can deprecate this extension and eventually remove it in a future release.

Note that no-cache-filter and output are not yet supported by the official specification.

crazy-max avatar Feb 25 '25 10:02 crazy-max

I don't get this. Is this expecting that bake will never add new fields in the definition? Plus, there are many fields in bake definition not supported in compose build block.

tonistiigi avatar Feb 25 '25 17:02 tonistiigi

Is this expecting that bake will never add new fields in the definition? Plus, there are many fields in bake definition not supported in compose build block.

No it just means that the official compose specification needs to add new fields to build block. x-bake was meaningful when there was no parity between bake fields and the official spec at the time.

Only missing fields from the official spec that are supported today in x-bake extension are no-cache-filter and output. We can postpone deprecation until these fields made into the official spec.

crazy-max avatar Feb 26 '25 09:02 crazy-max

Put this one in draft until missing fields are supported by the compose spec.

crazy-max avatar Apr 07 '25 12:04 crazy-max

We'll need to replace this PR with another that uses the warning path

thompson-shaun avatar May 01 '25 15:05 thompson-shaun