buildx icon indicating copy to clipboard operation
buildx copied to clipboard
verified publisher icon docker

tests: handle multiple docker versions

Open crazy-max opened this issue 1 year ago • 3 comments

  • ~needs https://github.com/moby/buildkit/pull/4736~

crazy-max avatar Mar 05 '24 10:03 crazy-max

@tonistiigi As discussed we could also handle builders through docker context with specific dind image as follow-up.

crazy-max avatar Mar 07 '24 18:03 crazy-max

These seem relevant to this pr: https://github.com/docker/buildx/blob/4327ee73b18949e47eb1c865daa262af095cf974/tests/build.go#L442-L443 https://github.com/docker/buildx/blob/4327ee73b18949e47eb1c865daa262af095cf974/tests/build.go#L576-L577 https://github.com/docker/buildx/blob/4327ee73b18949e47eb1c865daa262af095cf974/tests/build.go#L643-L644

davhdavh avatar Mar 08 '24 09:03 davhdavh

These seem relevant to this pr:

https://github.com/docker/buildx/blob/4327ee73b18949e47eb1c865daa262af095cf974/tests/build.go#L442-L443

https://github.com/docker/buildx/blob/4327ee73b18949e47eb1c865daa262af095cf974/tests/build.go#L576-L577

https://github.com/docker/buildx/blob/4327ee73b18949e47eb1c865daa262af095cf974/tests/build.go#L643-L644

WDYM? This PR is about testing multiple dockerd versions. For BuildKit see https://github.com/docker/buildx/pull/2322

crazy-max avatar Mar 08 '24 13:03 crazy-max